Chore: Omitted tenant parameter for OutboundApplication Widget#1270
Open
Chore: Omitted tenant parameter for OutboundApplication Widget#1270
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the required tenant parameter from the OutboundApplicationsProps type definition, making it consistent with ApplicationsPortalProps. The change allows the OutboundApplication widget to be used without requiring a tenant parameter.
Key Changes
- Modified
OutboundApplicationsPropsto omit thetenantproperty fromWidgetProps - Added optional
onLogoutcallback toOutboundApplicationsProps
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
View your CI Pipeline Execution ↗ for commit 06b331a
☁️ Nx Cloud last updated this comment at |
Member
|
I'm not sure it's the proper solution It's not only react sdk , we need to handle in a lower level I suggest to sync with @tomerlichtash on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes https://github.com/descope/etc/issues/12898
Related PRs
Description
This should fix the issue where
tenantis required for the outbound application widget.Must